Bug 230426 - [iOS] Enable MSE in WKWebViews by default on iPad
Summary: [iOS] Enable MSE in WKWebViews by default on iPad
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-17 13:36 PDT by Jer Noble
Modified: 2021-09-21 11:26 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.30 KB, patch)
2021-09-17 13:43 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (5.87 KB, patch)
2021-09-17 13:54 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (4.30 KB, patch)
2021-09-17 13:57 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (4.39 KB, patch)
2021-09-20 08:59 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.08 KB, patch)
2021-09-20 09:22 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (6.21 KB, patch)
2021-09-20 13:45 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (5.98 KB, patch)
2021-09-20 14:03 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.11 KB, patch)
2021-09-20 14:25 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-09-17 13:36:56 PDT 
[iOS] Enable MSE in WKWebViews by default on iPad
Comment 1 Radar WebKit Bug Importer 2021-09-17 13:37:30 PDT 
<rdar://problem/83253822>
Comment 2 Jer Noble 2021-09-17 13:43:23 PDT 
Created attachment 438509 [details]
Patch
Comment 3 Jer Noble 2021-09-17 13:54:15 PDT 
Created attachment 438512 [details]
Patch
Comment 4 Jer Noble 2021-09-17 13:57:27 PDT 
Created attachment 438513 [details]
Patch
Comment 5 Jer Noble 2021-09-20 08:59:13 PDT 
Created attachment 438685 [details]
Patch
Comment 6 Jer Noble 2021-09-20 09:22:06 PDT 
Created attachment 438686 [details]
Patch
Comment 7 Sam Weinig 2021-09-20 13:25:04 PDT 
Comment on attachment 438686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438686&action=review

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:317
> +#if !PLATFORM(IOS_FAMILY)
> +bool defaultMediaSourceEnabled()
> +{
> +    return true;
> +}
> +#endif

There should be no reason for this. You can just add PLATFORM(IOS_FAMILY) as part of the predicate in WebPreferences.yaml
Comment 8 Jer Noble 2021-09-20 13:45:56 PDT 
Created attachment 438724 [details]
Patch
Comment 9 Jer Noble 2021-09-20 14:03:17 PDT 
Created attachment 438726 [details]
Patch
Comment 10 Jer Noble 2021-09-20 14:25:50 PDT 
Created attachment 438728 [details]
Patch
Comment 11 EWS 2021-09-21 11:26:53 PDT 
Committed r282829 (241960@main): <https://commits.webkit.org/241960@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438728 [details].