Bug 230399 - imported/w3c/web-platform-tests/webrtc/RTCDataChannel-close.html is flaky
Summary: imported/w3c/web-platform-tests/webrtc/RTCDataChannel-close.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-17 05:06 PDT by youenn fablet
Modified: 2021-09-21 10:07 PDT (History)
11 users (show)

See Also:

Attachments
Patch (18.37 KB, patch)
2021-09-17 06:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (18.55 KB, patch)
2021-09-17 07:06 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (22.48 KB, patch)
2021-09-20 05:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (22.47 KB, patch)
2021-09-21 08:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-09-17 05:06:03 PDT 
imported/w3c/web-platform-tests/webrtc/RTCDataChannel-close.html is flaky
Comment 1 youenn fablet 2021-09-17 06:23:45 PDT 
Created attachment 438466 [details]
Patch
Comment 2 youenn fablet 2021-09-17 07:06:40 PDT 
Created attachment 438470 [details]
Patch
Comment 3 youenn fablet 2021-09-20 05:10:45 PDT 
Created attachment 438659 [details]
Patch
Comment 4 EWS Watchlist 2021-09-20 05:11:41 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 youenn fablet 2021-09-20 07:29:27 PDT 
I move the resyncing of imported/w3c/web-platform-tests/webrtc/RTCDataChannel-close.html from https://bugs.webkit.org/show_bug.cgi?id=229549 to this patch so that we keep it not flaky.
Comment 6 Eric Carlson 2021-09-21 07:57:59 PDT 
Comment on attachment 438659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438659&action=review

> Source/WebCore/ChangeLog:11
> +        - We were creating the data channel handler at the time we were creating the data channel handler.

S/creating the data channel handler at the time/creating the data channel at the time/

> Source/WebCore/ChangeLog:18
> +        Covered by test no longer flaky.

and by updated test RTCDataChannel-close.html.
Comment 7 youenn fablet 2021-09-21 08:47:37 PDT 
Created attachment 438827 [details]
Patch
Comment 8 EWS 2021-09-21 10:06:06 PDT 
Committed r282825 (241956@main): <https://commits.webkit.org/241956@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438827 [details].
Comment 9 Radar WebKit Bug Importer 2021-09-21 10:07:36 PDT 
<rdar://problem/83356916>