Bug 230282 - Fix -Wredundant-move warnings
Summary: Fix -Wredundant-move warnings
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Keywords: InRadar
Depends on:
Reported: 2021-09-14 15:59 PDT by Michael Catanzaro
Modified: 2021-09-14 16:48 PDT (History)
4 users (show)

See Also:

Patch (2.22 KB, patch)
2021-09-14 16:00 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2021-09-14 15:59:25 PDT
Fix -Wredundant-move warnings

Hi Alex, I'm CCing you because you introduced one of these in 241547@main, and it technically requires owner approval to fix....
Comment 1 Michael Catanzaro 2021-09-14 16:00:28 PDT
Created attachment 438185 [details]
Comment 2 Michael Catanzaro 2021-09-14 16:01:47 PDT
(BTW the difference here is: GCC warns whenever a WTFMove is redundant in return values, whereas clang only warns when a WTFMove actually prevents copy elision from happening. I don't know the differences between the two cases.)
Comment 3 Michael Catanzaro 2021-09-14 16:04:13 PDT
Comment on attachment 438185 [details]

Comment 4 EWS 2021-09-14 16:48:01 PDT
Committed r282421 (241680@main): <https://commits.webkit.org/241680@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438185 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-14 16:48:22 PDT