RESOLVED FIXED 230155
Factor more text painting functions to TextBoxPainter 
https://bugs.webkit.org/show_bug.cgi?id=230155
Summary Factor more text painting functions to TextBoxPainter
Antti Koivisto
Reported 2021-09-10 09:09:05 PDT
from LegacyInlineTextBox
Attachments
Patch (24.14 KB, patch)
2021-09-10 09:15 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (25.97 KB, patch)
2021-09-10 09:23 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-09-10 09:15:58 PDT
Created attachment 437878 [details] Patch
Antti Koivisto
Comment 2 2021-09-10 09:23:38 PDT
Created attachment 437882 [details] Patch
zalan
Comment 3 2021-09-10 09:54:06 PDT
Comment on attachment 437882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437882&action=review > Source/WebCore/rendering/TextBoxPainter.cpp:368 > + auto y = ascent + 0.11035 * fontSize; > + auto height = 0.13247 * fontSize; science.
EWS
Comment 4 2021-09-10 10:16:50 PDT
Committed r282277 (241555@main): <https://commits.webkit.org/241555@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437882 [details].
Radar WebKit Bug Importer
Comment 5 2021-09-10 10:17:22 PDT
<rdar://problem/82978035>
Note You need to log in before you can comment on or make changes to this bug.