Bug 230147 - Factor painting functions from LegacyInlineTextBox into a class
Summary: Factor painting functions from LegacyInlineTextBox into a class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-10 05:28 PDT by Antti Koivisto
Modified: 2021-09-13 01:36 PDT (History)
14 users (show)

See Also:

Attachments
patch (37.35 KB, patch)
2021-09-10 05:34 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (36.95 KB, patch)
2021-09-10 05:56 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (36.54 KB, patch)
2021-09-10 05:59 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (36.78 KB, patch)
2021-09-10 06:14 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (37.10 KB, patch)
2021-09-10 06:29 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (37.62 KB, patch)
2021-09-10 06:39 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-09-10 05:28:14 PDT 
Add TextBoxPainter
Comment 1 Antti Koivisto 2021-09-10 05:34:08 PDT 
Created attachment 437852 [details]
patch
Comment 2 Antti Koivisto 2021-09-10 05:56:22 PDT 
Created attachment 437855 [details]
patch
Comment 3 Antti Koivisto 2021-09-10 05:59:16 PDT 
Created attachment 437856 [details]
patch
Comment 4 Antti Koivisto 2021-09-10 06:14:39 PDT 
Created attachment 437858 [details]
patch
Comment 5 Antti Koivisto 2021-09-10 06:29:03 PDT 
Created attachment 437861 [details]
patch
Comment 6 Antti Koivisto 2021-09-10 06:39:54 PDT 
Created attachment 437863 [details]
Patch
Comment 7 zalan 2021-09-10 08:04:06 PDT 
Comment on attachment 437863 [details]
Patch

omg it's happening!!!
Comment 8 EWS 2021-09-10 08:20:47 PDT 
Committed r282270 (241548@main): <https://commits.webkit.org/241548@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437863 [details].
Comment 9 Radar WebKit Bug Importer 2021-09-10 09:13:52 PDT 
<rdar://problem/82975105>
Comment 10 Diego Pino 2021-09-13 01:36:28 PDT 
This patch broke Ubuntu LTS/Debian compilation.

https://build.webkit.org/#/builders/68/builds/6472

Fixed in https://trac.webkit.org/changeset/282321/webkit