RESOLVED FIXED 230147
Factor painting functions from LegacyInlineTextBox into a class 
https://bugs.webkit.org/show_bug.cgi?id=230147
Summary Factor painting functions from LegacyInlineTextBox into a class
Antti Koivisto
Reported 2021-09-10 05:28:14 PDT
Add TextBoxPainter
Attachments
patch (37.35 KB, patch)
2021-09-10 05:34 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (36.95 KB, patch)
2021-09-10 05:56 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (36.54 KB, patch)
2021-09-10 05:59 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (36.78 KB, patch)
2021-09-10 06:14 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (37.10 KB, patch)
2021-09-10 06:29 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (37.62 KB, patch)
2021-09-10 06:39 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-09-10 05:34:08 PDT
Created attachment 437852 [details] patch
Antti Koivisto
Comment 2 2021-09-10 05:56:22 PDT
Created attachment 437855 [details] patch
Antti Koivisto
Comment 3 2021-09-10 05:59:16 PDT
Created attachment 437856 [details] patch
Antti Koivisto
Comment 4 2021-09-10 06:14:39 PDT
Created attachment 437858 [details] patch
Antti Koivisto
Comment 5 2021-09-10 06:29:03 PDT
Created attachment 437861 [details] patch
Antti Koivisto
Comment 6 2021-09-10 06:39:54 PDT
Created attachment 437863 [details] Patch
zalan
Comment 7 2021-09-10 08:04:06 PDT
Comment on attachment 437863 [details] Patch omg it's happening!!!
EWS
Comment 8 2021-09-10 08:20:47 PDT
Committed r282270 (241548@main): <https://commits.webkit.org/241548@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437863 [details].
Radar WebKit Bug Importer
Comment 9 2021-09-10 09:13:52 PDT
<rdar://problem/82975105>
Diego Pino
Comment 10 2021-09-13 01:36:28 PDT
This patch broke Ubuntu LTS/Debian compilation. https://build.webkit.org/#/builders/68/builds/6472 Fixed in https://trac.webkit.org/changeset/282321/webkit
Note You need to log in before you can comment on or make changes to this bug.