Bug 229873 - Drop calls to testRunner.setCloseRemainingWindowsWhenComplete() from layout tests
Summary: Drop calls to testRunner.setCloseRemainingWindowsWhenComplete() from layout t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 229838
Blocks:
  Show dependency tree / graph
 
Reported: 2021-09-03 08:42 PDT by Chris Dumez
Modified: 2021-09-03 10:43 PDT (History)
15 users (show)

See Also:

Attachments
Patch (112.96 KB, patch)
2021-09-03 08:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-09-03 08:42:37 PDT 
Drop calls to testRunner.setCloseRemainingWindowsWhenComplete() from layout tests, as it is a no-op.
Comment 1 Chris Dumez 2021-09-03 08:44:22 PDT 
Created attachment 437275 [details]
Patch
Comment 2 Sam Weinig 2021-09-03 09:36:32 PDT 
Nice. Thanks!
Comment 3 EWS 2021-09-03 09:42:07 PDT 
Committed r282004 (241311@main): <https://commits.webkit.org/241311@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437275 [details].
Comment 4 Radar WebKit Bug Importer 2021-09-03 09:43:19 PDT 
<rdar://problem/82727180>
Comment 5 Alexey Proskuryakov 2021-09-03 10:15:12 PDT 
Chris, why did you land despite EWS being red?
Comment 6 Chris Dumez 2021-09-03 10:16:05 PDT 
(In reply to Alexey Proskuryakov from comment #5)
> Chris, why did you land despite EWS being red?

Those failures cannot be caused by my patch as my patch is a no-op.