Bug 229684 - WKWebViewConfiguration._loadsSubresources=NO should prevent preconnecting
Summary: WKWebViewConfiguration._loadsSubresources=NO should prevent preconnecting
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2021-08-30 13:04 PDT by Alex Christensen
Modified: 2021-08-30 15:07 PDT (History)
7 users (show)

See Also:

Patch (3.99 KB, patch)
2021-08-30 13:05 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (10.19 KB, patch)
2021-08-30 14:09 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-08-30 13:04:14 PDT
WKWebViewConfiguration._loadsSubresources=NO should prevent preconnecting
Comment 1 Alex Christensen 2021-08-30 13:05:15 PDT
Created attachment 436802 [details]
Comment 2 Tim Horton 2021-08-30 13:08:27 PDT
Comment on attachment 436802 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=436802&action=review

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:778
> +    if (auto* corePage = webPage.corePage(); corePage && (!corePage->allowsLoadFromURL(request.url()) || !corePage->loadsSubresources())) {

Wonder if we should just tuck this into allowsLoadFromURL (make it take a "is a subresource" param and then it checks both the allowed-hosts list and loadsSubresources)?
Comment 3 Alex Christensen 2021-08-30 14:09:18 PDT
Created attachment 436811 [details]
Comment 4 EWS 2021-08-30 15:06:09 PDT
Committed r281777 (241114@main): <https://commits.webkit.org/241114@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436811 [details].
Comment 5 Radar WebKit Bug Importer 2021-08-30 15:07:16 PDT