Bug 229633 - [Cocoa] Drawing system fallback fonts to canvas causes a crash
Summary: [Cocoa] Drawing system fallback fonts to canvas causes a crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-27 15:32 PDT by Myles C. Maxfield
Modified: 2021-09-11 02:07 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.27 KB, patch)
2021-08-27 15:34 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (7.37 KB, patch)
2021-08-27 15:35 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (9.34 KB, patch)
2021-08-27 15:41 PDT, Myles C. Maxfield
wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch for committing (9.12 KB, patch)
2021-08-27 15:56 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-08-27 15:32:56 PDT
[Cocoa] Drawing system fallback fonts to canvas causes a crash
Comment 1 Myles C. Maxfield 2021-08-27 15:34:29 PDT
Created attachment 436683 [details]
Patch
Comment 2 Myles C. Maxfield 2021-08-27 15:35:00 PDT
<rdar://problem/81889036>
Comment 3 Myles C. Maxfield 2021-08-27 15:35:17 PDT
Created attachment 436684 [details]
Patch
Comment 4 Wenson Hsieh 2021-08-27 15:40:03 PDT
Comment on attachment 436683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436683&action=review

r=mews!

> LayoutTests/fast/text/system-fallback-canvas.html:1
> +<!DOCTYPE html>

Might be nice to have a ref-mismatch test to ensure that at least something was drawn to the canvas.
Comment 5 Myles C. Maxfield 2021-08-27 15:41:30 PDT
Created attachment 436685 [details]
Patch
Comment 6 Wenson Hsieh 2021-08-27 15:54:15 PDT
Comment on attachment 436685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436685&action=review

> LayoutTests/fast/text/draw-synthetic-system-bold-font-into-canvas-expected-mismatch.html:4
> +<script src="../../resources/js-test.js"></script>

This should probably be removed.
Comment 7 Myles C. Maxfield 2021-08-27 15:56:47 PDT
Created attachment 436687 [details]
Patch for committing
Comment 8 EWS 2021-08-31 00:18:22 PDT
Committed r281792 (241129@main): <https://commits.webkit.org/241129@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436687 [details].