229552 – Remove all WTR output before Content-Type:text/plain for WebRTC tests on BigSur

Bug 229552 - Remove all WTR output before Content-Type:text/plain for WebRTC tests on BigSur

Summary: Remove all WTR output before Content-Type:text/plain for WebRTC tests on BigSur

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebRTC (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	youenn fablet

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2021-08-26 05:57 PDT by youenn fablet
Modified:	2021-09-27 16:27 PDT (History)
CC List:	6 users (show)

See Also:	230733

Attachments
Patch (2.15 KB, patch) 2021-08-26 06:01 PDT, youenn fablet	no flags	Details \| Formatted Diff \| Diff
Patch (1.65 KB, patch) 2021-09-02 23:58 PDT, youenn fablet	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description youenn fablet 2021-08-26 05:57:41 PDT

Remove all WTR output before Content-Type:text/plain for WebRTC tests

Comment 1 youenn fablet 2021-08-26 05:59:11 PDT

Following on https://bugs.webkit.org/show_bug.cgi?id=229188, filtering needs to be harsher to get stable results.
See https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r280628%20(4289)/webrtc/video-setDirection-pretty-diff.html

Comment 2 youenn fablet 2021-08-26 06:01:41 PDT

Created attachment 436502 [details]
Patch

Comment 3 Radar WebKit Bug Importer 2021-08-26 07:52:38 PDT

<rdar://problem/82390178>

Comment 4 Jonathan Bedard 2021-08-30 10:27:07 PDT

Comment on attachment 436502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436502&action=review

> Tools/Scripts/webkitpy/port/driver.py:126
> +            if re.match(detector, result[0]):

This is a pretty large change, do we know if any of our existing detector strings are actually regexes? If the goal is to just string all logging, we could add the empty string to logging_detectors, in python `'' in 'some string'` is always true.

Comment 5 youenn fablet 2021-09-02 23:58:19 PDT

Created attachment 437247 [details]
Patch

Comment 6 EWS 2021-09-03 06:28:12 PDT

Committed r281988 (241295@main): <https://commits.webkit.org/241295@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437247 [details].