Bug 229512 – Remove unnecessary ITP memory store code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kate Cheney]

Remove unnecessary ITP memory store code

[Kate Cheney]

Created attachment 436420 [details]
Patch

[Kate Cheney]

Created attachment 436431 [details]
Patch

[Kate Cheney]

Created attachment 436433 [details]
Patch

[John Wilander]

Comment on attachment 436433 [details]
Patch

I didn't review this line-by-line. You're change log description makes sense so I'll just ask a few questions:
1) Did you maintain any relevant commenting in the code you're deleting? We may have insights in there we don't want to lose.
2) Did you delete the obsolete test cases? (Sorry to be so lazy)
3) Did you delete the obsolete TestRunner and test API functionality?
4) Did you search for and change text references to ResourceLoadStatisticsMemoryStore and ResourceLoadStatisticsDatabaseStore?
5) Did you remove "Memory" and "Database" from any remaining TestRunner and test API changes.

[Kate Cheney]

(In reply to John Wilander from comment #4)
> Comment on attachment 436433 [details]
> Patch
> 
> I didn't review this line-by-line. You're change log description makes sense
> so I'll just ask a few questions:
> 1) Did you maintain any relevant commenting in the code you're deleting? We
> may have insights in there we don't want to lose.

Yes, I copy-pasted all existing code.

> 2) Did you delete the obsolete test cases? (Sorry to be so lazy)

Alex removed most test cases when he deleted the plist in https://bugs.webkit.org/show_bug.cgi?id=217063. I see a couple API tests that were missed, I'll remove those as well.

> 3) Did you delete the obsolete TestRunner and test API functionality?

Not needed, this was done in https://bugs.webkit.org/show_bug.cgi?id=217063.

> 4) Did you search for and change text references to
> ResourceLoadStatisticsMemoryStore and ResourceLoadStatisticsDatabaseStore?

Yes, big find + replace.

> 5) Did you remove "Memory" and "Database" from any remaining TestRunner and
> test API changes.

No! I need to do this.

Thanks for the comments!

[Kate Cheney]

Created attachment 436589 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/82644309>

[Kate Cheney]

Created attachment 438493 [details]
Patch

[John Wilander]

Comment on attachment 438493 [details]
Patch

r=me

[John Wilander]

I assume you'll take care of the things we discussed above.

[Kate Cheney]

(In reply to John Wilander from comment #10)
> I assume you'll take care of the things we discussed above.

Yes, I handled test changes in this patch, and will address everything else (keeping commenting, and changing text references) in the part 2 of this patch.

[EWS]

Committed r282711 (241848@main): <https://commits.webkit.org/241848@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438493 [details].