Bug 229278 - Replace the uint64_t used to identify taps with an ObjectIdentifier<> type
Summary: Replace the uint64_t used to identify taps with an ObjectIdentifier<> type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 229302 229308
  Show dependency tree / graph
 
Reported: 2021-08-18 20:43 PDT by Simon Fraser (smfr)
Modified: 2021-08-19 15:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (42.56 KB, patch)
2021-08-18 20:46 PDT, Simon Fraser (smfr) 		wenson_hsieh: review+
wenson_hsieh: commit-queue-
Details | Formatted Diff | Diff
Patch (42.44 KB, patch)
2021-08-19 11:01 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-08-18 20:43:53 PDT 
Replace the uint64_t used to identify taps with an ObjectIdentifier<> type
Comment 1 Simon Fraser (smfr) 2021-08-18 20:46:08 PDT 
Created attachment 435837 [details]
Patch
Comment 2 Wenson Hsieh 2021-08-18 20:55:46 PDT 
Comment on attachment 435837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435837&action=review

r=me once this is rebased on trunk

> Source/WebKit/Shared/IdentifierTypes.h:34
> +

Nice. This seems like a good place to put the various other identifier types used in WebKit2 that are currently just in their own headers, but we can do that later.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3113
> +

Nit - stray newline here.
Comment 3 Simon Fraser (smfr) 2021-08-19 11:01:53 PDT 
Created attachment 435884 [details]
Patch
Comment 4 EWS 2021-08-19 15:48:33 PDT 
Committed r281276 (240701@main): <https://commits.webkit.org/240701@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435884 [details].
Comment 5 Radar WebKit Bug Importer 2021-08-19 15:49:17 PDT 
<rdar://problem/82145392>