Bug 228897 - REGRESSION(r280756): Broke gtk build
Summary: REGRESSION(r280756): Broke gtk build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords: InRadar
Depends on:
Blocks: 228809
  Show dependency treegraph
 
Reported: 2021-08-07 09:27 PDT by WebKit Commit Bot
Modified: 2021-08-07 11:01 PDT (History)
22 users (show)

See Also:


Attachments
REVERT of r280756 (59.23 KB, patch)
2021-08-07 09:28 PDT, WebKit Commit Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2021-08-07 09:27:46 PDT
https://commits.webkit.org/r280756 introduced a regression:
Broke gtk build

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2021-08-07 09:28:01 PDT
Created attachment 435132 [details]
REVERT of r280756

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 EWS 2021-08-07 09:34:47 PDT
Committed r280757 (240342@main): <https://commits.webkit.org/240342@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435132 [details].
Comment 3 Radar WebKit Bug Importer 2021-08-07 09:35:23 PDT
<rdar://problem/81654605>
Comment 4 Myles C. Maxfield 2021-08-07 10:52:35 PDT
EWS was green 🙁
Comment 5 Aakash Jain 2021-08-07 11:01:49 PDT
(In reply to Myles C. Maxfield from comment #4)
> EWS was green 🙁
The patch was landed manually (not through commit-queue). I didn't check if commit was exactly same as the patch which passed EWS. EWS did indicate this issue on previous version of the patch in https://ews-build.webkit.org/#/builders/36/builds/41836