Bug 228886 - Clarify some identifier naming in RemoteRenderingBackend
Summary: Clarify some identifier naming in RemoteRenderingBackend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-06 20:05 PDT by Simon Fraser (smfr)
Modified: 2021-08-06 21:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.39 KB, patch)
2021-08-06 20:06 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-08-06 20:05:15 PDT 
Clarify some identifier naming in RemoteRenderingBackend
Comment 1 Simon Fraser (smfr) 2021-08-06 20:06:03 PDT 
Created attachment 435111 [details]
Patch
Comment 2 Said Abou-Hallawa 2021-08-06 20:13:52 PDT 
Comment on attachment 435111 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435111&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:341
> +    // FIXME: All the callers pass m_pendingWakeupInfo.arguments so the body of this function should just be this loop.

I am not sure I understand this comment. How should this function look in the future?
Comment 3 EWS 2021-08-06 21:29:59 PDT 
Committed r280754 (240339@main): <https://commits.webkit.org/240339@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435111 [details].
Comment 4 Radar WebKit Bug Importer 2021-08-06 21:30:24 PDT 
<rdar://problem/81644215>