We are terminating too many simulator processes in our simulator management code, and we're not recovering when failing to delete a simulated device.
<rdar://problem/81479508>
Created attachment 434861 [details] Patch
Comment on attachment 434861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434861&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:-508 > - if SimulatedDeviceManager._managing_simulator_app: why don't we need this anymore?
Overall, how do you come up with this? How do we know that we won't be killing too less (or different thing than needed) after this?
Comment on attachment 434861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434861&action=review >> Tools/Scripts/webkitpy/xcode/simulated_device.py:-508 >> - if SimulatedDeviceManager._managing_simulator_app: > > why don't we need this anymore? Because CoreSimulator is mature enough now that we don't need to do this any more, we end up killing processes before they finish tearing themselves down.
(In reply to Aakash Jain from comment #4) > Overall, how do you come up with this? How do we know that we won't be > killing too less (or different thing than needed) after this? We will be killing less, in every case. That's why I did Simulator.app instead of Simulator. I started to play around killing less processes and seeing what that did, it made interacting with simctl much more stable. Which isn't particularly surprising, we shouldn't really need to kill CoreSimulator processes.
Comment on attachment 434861 [details] Patch Seems worth trying!
Committed r280618 (240231@main): <https://commits.webkit.org/240231@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434861 [details].