Bug 228734 - Import css/css-sizing/aspect-ratio tests from WPT
Summary: Import css/css-sizing/aspect-ratio tests from WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: cathiechen
URL:
Keywords: InRadar
Depends on:
Blocks: 228076
  Show dependency tree / graph
 
Reported: 2021-08-03 02:39 PDT by cathiechen
Modified: 2021-08-03 08:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.87 KB, patch)
2021-08-03 07:36 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (11.86 KB, patch)
2021-08-03 07:47 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description cathiechen 2021-08-03 02:39:44 PDT 
Import css/css-sizing/aspect-ratio tests from WPT
Comment 1 cathiechen 2021-08-03 07:36:20 PDT 
Created attachment 434831 [details]
Patch
Comment 2 Rob Buis 2021-08-03 07:40:00 PDT 
Comment on attachment 434831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434831&action=review

> LayoutTests/TestExpectations:4714
> +webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-027.html [ ImageOnlyFailure ]

You can probably refer to https://bugs.webkit.org/show_bug.cgi?id=228076 here.

> LayoutTests/TestExpectations:4715
> +webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-028.html [ ImageOnlyFailure ]

Ditto.
Comment 3 cathiechen 2021-08-03 07:44:32 PDT 
Comment on attachment 434831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434831&action=review

Hi Rob,
Thanks for the review!

>> LayoutTests/TestExpectations:4714
>> +webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-027.html [ ImageOnlyFailure ]
> 
> You can probably refer to https://bugs.webkit.org/show_bug.cgi?id=228076 here.

Done.

>> LayoutTests/TestExpectations:4715
>> +webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-028.html [ ImageOnlyFailure ]
> 
> Ditto.

Done.
Comment 4 cathiechen 2021-08-03 07:47:12 PDT 
Created attachment 434832 [details]
Patch
Comment 5 EWS 2021-08-03 08:50:36 PDT 
Committed r280592 (240214@main): <https://commits.webkit.org/240214@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434832 [details].
Comment 6 Radar WebKit Bug Importer 2021-08-03 08:51:24 PDT 
<rdar://problem/81464005>