Bug 228707 - Add basestring compatibility for Python3 in webkitcorepy
Summary: Add basestring compatibility for Python3 in webkitcorepy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Russell Epstein
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-02 10:57 PDT by Russell Epstein
Modified: 2021-08-02 12:54 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.24 KB, patch)
2021-08-02 11:06 PDT, Russell Epstein
no flags Details | Formatted Diff | Diff
Patch (2.60 KB, patch)
2021-08-02 11:15 PDT, Russell Epstein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Russell Epstein 2021-08-02 10:57:56 PDT
We should add basestring to webkitcorepy to improve python2-3 compatibility.
Comment 1 Russell Epstein 2021-08-02 11:06:12 PDT
Created attachment 434772 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-08-02 11:07:04 PDT
<rdar://problem/81420233>
Comment 3 Jonathan Bedard 2021-08-02 11:10:39 PDT
Comment on attachment 434772 [details]
Patch

Might want to bump the version numbers in webkitcorepy/setup.py and webkitcorepy/__init__.py
Comment 4 Russell Epstein 2021-08-02 11:15:44 PDT
Created attachment 434774 [details]
Patch
Comment 5 EWS 2021-08-02 12:54:31 PDT
Committed r280550 (240177@main): <https://commits.webkit.org/240177@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434774 [details].