Bug 228706 - WebKitTestRunner should dump current results in the case of a timeout
Summary: WebKitTestRunner should dump current results in the case of a timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-02 10:14 PDT by Jer Noble
Modified: 2021-08-03 15:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2021-08-02 10:20 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (5.45 KB, patch)
2021-08-02 10:23 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-08-02 10:14:35 PDT 
WebKitTestRunner should dump current results in the case of a timeout
Comment 1 Jer Noble 2021-08-02 10:20:11 PDT 
<rdar://79154019>
Comment 2 Jer Noble 2021-08-02 10:20:41 PDT 
Created attachment 434767 [details]
Patch
Comment 3 Jer Noble 2021-08-02 10:23:07 PDT 
Created attachment 434768 [details]
Patch
Comment 4 Jonathan Bedard 2021-08-03 11:22:30 PDT 
Comment on attachment 434768 [details]
Patch

Played around with this a bit, tests which currently time out continue to, but a more reasonable diff. This seems like a good thing to land, and Jer is familiar with the media tests which are most likely to benefit from this sort of change.
Comment 5 EWS 2021-08-03 15:23:51 PDT 
Committed r280619 (240232@main): <https://commits.webkit.org/240232@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434768 [details].