RESOLVED FIXED 228633
[Media Controls] Add an option for having no scrubber on the time control and parameterize margin 
https://bugs.webkit.org/show_bug.cgi?id=228633
Summary [Media Controls] Add an option for having no scrubber on the time control and...
Dean Jackson
Reported 2021-07-30 01:09:00 PDT
[Media Controls] Add an option for having no scrubber on the time control and parameterize margin
Attachments
Patch (9.22 KB, patch)
2021-07-30 01:24 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-07-30 01:09:56 PDT
<rdar://problem/81314458>
Dean Jackson
Comment 2 2021-07-30 01:24:34 PDT
Created attachment 434611 [details] Patch
Tim Horton
Comment 3 2021-07-30 01:28:03 PDT
Comment on attachment 434611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434611&action=review > Source/WebCore/Modules/modern-media-controls/controls/slider.js:147 > + if (style === Slider.KnobStyle.Bar) Normally I would say "use `case` so you force people adding new styles to come back here and make a decision", but JavaScript is all loosey goosey so it doesn't really matter? > Source/WebCore/Modules/modern-media-controls/controls/slider.js:225 > + None: "none" maintain the trailing comma? :D
Dean Jackson
Comment 4 2021-07-30 09:22:03 PDT
Committed r280477 (240112@main): <https://commits.webkit.org/240112@main>
Note You need to log in before you can comment on or make changes to this bug.