Bug 228633 - [Media Controls] Add an option for having no scrubber on the time control and parameterize margin
Summary: [Media Controls] Add an option for having no scrubber on the time control and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-30 01:09 PDT by Dean Jackson
Modified: 2021-07-30 09:22 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.22 KB, patch)
2021-07-30 01:24 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2021-07-30 01:09:00 PDT 
[Media Controls] Add an option for having no scrubber on the time control and parameterize margin
Comment 1 Radar WebKit Bug Importer 2021-07-30 01:09:56 PDT 
<rdar://problem/81314458>
Comment 2 Dean Jackson 2021-07-30 01:24:34 PDT 
Created attachment 434611 [details]
Patch
Comment 3 Tim Horton 2021-07-30 01:28:03 PDT 
Comment on attachment 434611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434611&action=review

> Source/WebCore/Modules/modern-media-controls/controls/slider.js:147
> +            if (style === Slider.KnobStyle.Bar)

Normally I would say "use `case` so you force people adding new styles to come back here and make a decision", but JavaScript is all loosey goosey so it doesn't really matter?

> Source/WebCore/Modules/modern-media-controls/controls/slider.js:225
> +    None: "none"

maintain the trailing comma? :D
Comment 4 Dean Jackson 2021-07-30 09:22:03 PDT 
Committed r280477 (240112@main): <https://commits.webkit.org/240112@main>