Bug 228620 - [macOS|AS] VTImageRotationSession returns a kVTImageRotationNotSupportedErr, breaks painting rotated videos
Summary: [macOS|AS] VTImageRotationSession returns a kVTImageRotationNotSupportedErr, ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks: 228560
  Show dependency tree / graph
 
Reported: 2021-07-29 16:15 PDT by Jer Noble
Modified: 2021-07-29 19:32 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2021-07-29 16:23 PDT, Jer Noble 		pvollan: review+
Details | Formatted Diff | Diff
Patch for landing (1.41 KB, patch)
2021-07-29 17:02 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-07-29 16:15:17 PDT 
[macOS|AS] VTImageRotationSession returns a kVTImageRotationNotSupportedErr, breaks painting rotated videos
Comment 1 Jer Noble 2021-07-29 16:23:28 PDT 
Created attachment 434586 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-07-29 16:39:33 PDT 
<rdar://problem/81297600>
Comment 3 Per Arne Vollan 2021-07-29 16:46:44 PDT 
Comment on attachment 434586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434586&action=review

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:124
> +        (iokit-registry-entry-class "IOSurfaceAcceleratorClient"))

I think it would be good to add a check for the CPU type.
Comment 4 Per Arne Vollan 2021-07-29 16:47:48 PDT 
Comment on attachment 434586 [details]
Patch

R=me, with a CPU check.
Comment 5 Jer Noble 2021-07-29 17:02:32 PDT 
Created attachment 434591 [details]
Patch for landing
Comment 6 EWS 2021-07-29 19:32:33 PDT 
Committed r280465 (240100@main): <https://commits.webkit.org/240100@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434591 [details].