Bug 228251 - Add a method to WebAccessibilityObjectWrapper so that clients can retrieve the text of each line and their corresponding bounding rectangles.
Summary: Add a method to WebAccessibilityObjectWrapper so that clients can retrieve th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-23 15:09 PDT by Andres Gonzalez
Modified: 2021-07-23 20:48 PDT (History)
9 users (show)

See Also:

Attachments
Patch (20.00 KB, patch)
2021-07-23 15:32 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2021-07-23 15:09:57 PDT 
Add a method to WebAccessibilityObjectWrapper so that clients can retrieve the text of each line and their corresponding bounding rectangles.
Comment 1 Radar WebKit Bug Importer 2021-07-23 15:10:07 PDT 
<rdar://problem/81038192>
Comment 2 Andres Gonzalez 2021-07-23 15:20:33 PDT 
rdar://77184036
Comment 3 Andres Gonzalez 2021-07-23 15:32:00 PDT 
Created attachment 434130 [details]
Patch
Comment 4 chris fleizach 2021-07-23 17:23:02 PDT 
Comment on attachment 434130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434130&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2889
> +                  @"text": line.second.get() };

ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2889:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 11 files
Comment 5 EWS 2021-07-23 20:48:11 PDT 
Committed r280282 (239940@main): <https://commits.webkit.org/239940@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434130 [details].