Bug 228239 - [Cocoa] Playback stalls on bilibili.com
Summary: [Cocoa] Playback stalls on bilibili.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-23 11:15 PDT by Jer Noble
Modified: 2021-07-26 12:37 PDT (History)
13 users (show)

See Also:

Attachments
Patch (14.44 KB, patch)
2021-07-23 11:39 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (15.27 KB, patch)
2021-07-23 11:50 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (16.79 KB, patch)
2021-07-23 11:54 PDT, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (16.83 KB, patch)
2021-07-26 10:57 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-07-23 11:15:25 PDT 
[Cocoa] Playback stalls on bilibili.com
Comment 1 Jer Noble 2021-07-23 11:16:24 PDT 
<rdar://80419477>
Comment 2 Jer Noble 2021-07-23 11:39:47 PDT 
Created attachment 434105 [details]
Patch
Comment 3 Jer Noble 2021-07-23 11:50:43 PDT 
Created attachment 434106 [details]
Patch
Comment 4 Jer Noble 2021-07-23 11:54:11 PDT 
Created attachment 434107 [details]
Patch
Comment 5 Eric Carlson 2021-07-26 10:31:11 PDT 
Comment on attachment 434107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434107&action=review

> Source/WebCore/ChangeLog:18
> +        To make the call less ambiguous, add a MediaPlayer and MediaPlayerPrivate effectiveRate

Nit: you should pull the "()" back to the previous line
Comment 6 Jer Noble 2021-07-26 10:57:10 PDT 
Created attachment 434215 [details]
Patch for landing
Comment 7 EWS 2021-07-26 12:36:59 PDT 
Committed r280308 (239958@main): <https://commits.webkit.org/239958@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434215 [details].