WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
228236
[macOS] Reduce sandbox logging
https://bugs.webkit.org/show_bug.cgi?id=228236
Summary
[macOS] Reduce sandbox logging
Per Arne Vollan
Reported
2021-07-23 08:25:59 PDT
Reduce the sandbox logging on macOS.
Attachments
Patch
(11.31 KB, patch)
2021-07-23 08:27 PDT
,
Per Arne Vollan
thorton
: review+
Details
Formatted Diff
Diff
Patch
(11.40 KB, patch)
2021-07-23 11:36 PDT
,
Per Arne Vollan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Per Arne Vollan
Comment 1
2021-07-23 08:27:58 PDT
Created
attachment 434089
[details]
Patch
Tim Horton
Comment 2
2021-07-23 11:28:57 PDT
Comment on
attachment 434089
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=434089&action=review
> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1425 > -(allow mach-lookup (with report)
did you mean to lose (with report) here?
> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1460 > - (with report) (with telemetry-backtrace)
did you mean to lose (with report) here?
Tim Horton
Comment 3
2021-07-23 11:29:13 PDT
Comment on
attachment 434089
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=434089&action=review
> Source/WebKit/ChangeLog:9 > +
A few more words would be great
Per Arne Vollan
Comment 4
2021-07-23 11:30:18 PDT
(In reply to Tim Horton from
comment #2
)
> Comment on
attachment 434089
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=434089&action=review
> > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1425 > > -(allow mach-lookup (with report) > > did you mean to lose (with report) here? > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1460 > > - (with report) (with telemetry-backtrace) > > did you mean to lose (with report) here?
Yes, this is to avoid the cost of generating reports. Thanks for reviewing!
Per Arne Vollan
Comment 5
2021-07-23 11:30:30 PDT
(In reply to Tim Horton from
comment #3
)
> Comment on
attachment 434089
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=434089&action=review
> > > Source/WebKit/ChangeLog:9 > > + > > A few more words would be great
Will fix!
Per Arne Vollan
Comment 6
2021-07-23 11:36:24 PDT
Created
attachment 434104
[details]
Patch
EWS
Comment 7
2021-07-23 12:57:31 PDT
Committed
r280254
(
239921@main
): <
https://commits.webkit.org/239921@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 434104
[details]
.
Radar WebKit Bug Importer
Comment 8
2021-07-23 12:58:14 PDT
<
rdar://problem/81032767
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug