Bug 228236 - [macOS] Reduce sandbox logging
Summary: [macOS] Reduce sandbox logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-23 08:25 PDT by Per Arne Vollan
Modified: 2021-07-23 12:58 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.31 KB, patch)
2021-07-23 08:27 PDT, Per Arne Vollan 		thorton: review+
Details | Formatted Diff | Diff
Patch (11.40 KB, patch)
2021-07-23 11:36 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-07-23 08:25:59 PDT 
Reduce the sandbox logging on macOS.
Comment 1 Per Arne Vollan 2021-07-23 08:27:58 PDT 
Created attachment 434089 [details]
Patch
Comment 2 Tim Horton 2021-07-23 11:28:57 PDT 
Comment on attachment 434089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434089&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1425
> -(allow mach-lookup (with report)

did you mean to lose (with report) here?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1460
> -        (with report) (with telemetry-backtrace)

did you mean to lose (with report) here?
Comment 3 Tim Horton 2021-07-23 11:29:13 PDT 
Comment on attachment 434089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434089&action=review

> Source/WebKit/ChangeLog:9
> +

A few more words would be great
Comment 4 Per Arne Vollan 2021-07-23 11:30:18 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 434089 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434089&action=review
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1425
> > -(allow mach-lookup (with report)
> 
> did you mean to lose (with report) here?
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1460
> > -        (with report) (with telemetry-backtrace)
> 
> did you mean to lose (with report) here?

Yes, this is to avoid the cost of generating reports.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2021-07-23 11:30:30 PDT 
(In reply to Tim Horton from comment #3)
> Comment on attachment 434089 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434089&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +
> 
> A few more words would be great

Will fix!
Comment 6 Per Arne Vollan 2021-07-23 11:36:24 PDT 
Created attachment 434104 [details]
Patch
Comment 7 EWS 2021-07-23 12:57:31 PDT 
Committed r280254 (239921@main): <https://commits.webkit.org/239921@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434104 [details].
Comment 8 Radar WebKit Bug Importer 2021-07-23 12:58:14 PDT 
<rdar://problem/81032767>