Bug 228107 - IBeam cursor is horizontal in Mail compose window
Summary: IBeam cursor is horizontal in Mail compose window
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-20 08:13 PDT by Kate Cheney
Modified: 2021-07-20 12:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.44 KB, patch)
2021-07-20 08:15 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch (6.28 KB, patch)
2021-07-20 10:41 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2021-07-20 08:13:02 PDT 
IBeam cursor is horizontal in Mail compose window
Comment 1 Kate Cheney 2021-07-20 08:15:38 PDT 
Created attachment 433875 [details]
Patch
Comment 2 Kate Cheney 2021-07-20 08:16:00 PDT 
rdar://80636912
Comment 3 Simon Fraser (smfr) 2021-07-20 10:02:11 PDT 
Comment on attachment 433875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433875&action=review

> Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:76
> +    std::optional<bool> isHorizontalWritingMode;

Would it be simpler to just call this isVerticalWritingMode and default to false? That's effectively what the code is doing.
Comment 4 Kate Cheney 2021-07-20 10:37:27 PDT 
Comment on attachment 433875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433875&action=review

>> Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:76
>> +    std::optional<bool> isHorizontalWritingMode;
> 
> Would it be simpler to just call this isVerticalWritingMode and default to false? That's effectively what the code is doing.

Yes, it would be.
Comment 5 Kate Cheney 2021-07-20 10:41:23 PDT 
Created attachment 433881 [details]
Patch
Comment 6 EWS 2021-07-20 12:44:27 PDT 
Committed r280098 (239815@main): <https://commits.webkit.org/239815@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433881 [details].