Bug 228050 - [LFC][IFC] LineBox provides redundant geometry information
Summary: [LFC][IFC] LineBox provides redundant geometry information
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-17 09:16 PDT by zalan
Modified: 2021-08-20 13:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.49 KB, patch)
2021-07-17 09:35 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (14.84 KB, patch)
2021-07-17 11:24 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (14.36 KB, patch)
2021-08-19 17:01 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (24.25 KB, patch)
2021-08-19 20:13 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (24.34 KB, patch)
2021-08-20 08:49 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-07-17 09:16:56 PDT 
LineBoxGeometry is where we need this information
Comment 1 zalan 2021-07-17 09:35:21 PDT 
Created attachment 433732 [details]
Patch
Comment 2 zalan 2021-07-17 11:24:29 PDT 
Created attachment 433733 [details]
Patch
Comment 3 Sam Weinig 2021-07-18 12:35:11 PDT 
Comment on attachment 433733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433733&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:359
> +        m_logicalHeight =  { };

extra space.
Comment 4 Radar WebKit Bug Importer 2021-07-24 09:17:15 PDT 
<rdar://problem/81057163>
Comment 5 zalan 2021-08-19 17:01:06 PDT 
Created attachment 435924 [details]
Patch
Comment 6 zalan 2021-08-19 20:13:16 PDT 
Created attachment 435935 [details]
Patch
Comment 7 zalan 2021-08-20 08:49:32 PDT 
Created attachment 435993 [details]
Patch
Comment 8 EWS 2021-08-20 13:50:50 PDT 
Committed r281335 (240752@main): <https://commits.webkit.org/240752@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435993 [details].