Bug 227934 - [GStreamer] test media/media-source/media-webm-vorbis-partial.html fails
Summary: [GStreamer] test media/media-source/media-webm-vorbis-partial.html fails
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-13 17:46 PDT by Arcady Goldmints-Orlov
Modified: 2024-01-22 01:29 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2021-07-13 17:50 PDT, Arcady Goldmints-Orlov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arcady Goldmints-Orlov 2021-07-13 17:46:10 PDT
These tests have been failing since they were added. Example below:

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/media-source/media-webm-opus-partial-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/media-source/media-webm-opus-partial-actual.txt
@@ -11,12 +11,12 @@
 RUN(sourceBuffer.appendBuffer(partial1))
 EVENT(update)
 EXPECTED (sourceBuffer.buffered.length == '1') OK
-EXPECTED (sourceBuffer.buffered.end(0) == '3.621') OK
+EXPECTED (sourceBuffer.buffered.end(0) == '3.621'), OBSERVED '3.6145' FAIL
 Complete the partial media segment.
 RUN(sourceBuffer.appendBuffer(partial2))
 EVENT(update)
 EXPECTED (sourceBuffer.buffered.length == '1') OK
-EXPECTED (sourceBuffer.buffered.end(0) == '10.001') OK
+EXPECTED (sourceBuffer.buffered.end(0) == '10.001'), OBSERVED '9.9945' FAIL
 Clean sourcebuffer of all content.
 RUN(sourceBuffer.remove(0, 100))
 EVENT(update)
@@ -24,11 +24,11 @@
 RUN(sourceBuffer.appendBuffer(loader.mediaSegment(1)))
 EVENT(update)
 EXPECTED (sourceBuffer.buffered.length == '1') OK
-EXPECTED (sourceBuffer.buffered.end(0) == '90.001') OK
+EXPECTED (sourceBuffer.buffered.end(0) == '90.001'), OBSERVED '89.9945' FAIL
 RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
 EVENT(update)
 EXPECTED (sourceBuffer.buffered.length == '2') OK
-EXPECTED (sourceBuffer.buffered.end(0) == '10.001') OK
-EXPECTED (sourceBuffer.buffered.end(1) == '90.001') OK
+EXPECTED (sourceBuffer.buffered.end(0) == '10.001'), OBSERVED '9.9945' FAIL
+EXPECTED (sourceBuffer.buffered.end(1) == '90.001'), OBSERVED '89.9945' FAIL
 END OF TEST
Comment 1 Arcady Goldmints-Orlov 2021-07-13 17:50:36 PDT
Created attachment 433466 [details]
Patch
Comment 2 Arcady Goldmints-Orlov 2021-07-13 17:51:37 PDT
Attached patch is for gardening the test failures. Not sure if it's a test issue, they are also apparently failing on mac.
Comment 3 EWS 2021-07-14 03:54:08 PDT
Committed r279907 (239656@main): <https://commits.webkit.org/239656@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433466 [details].
Comment 4 Radar WebKit Bug Importer 2021-07-14 03:55:17 PDT
<rdar://problem/80569141>
Comment 5 Philippe Normand 2021-07-14 04:29:14 PDT
Gardened. Patch might still be needed.
Comment 6 Alicia Boya García 2023-03-27 06:50:00 PDT
media/media-source/media-webm-opus-partial.html is passing after LayoutTests/media/media-source/content/test-opus.webm was modified by 260822@main
Comment 7 Philippe Normand 2024-01-22 01:28:51 PST
Only one issue left with media/media-source/media-webm-vorbis-partial.html:

EXPECTED (sourceBuffer.buffered.end(0).toFixed(2) == '1.34'), OBSERVED '1.33' FAIL