Bug 227678 - [GTK] Navigation swipe gesture can be triggered with mouse
Summary: [GTK] Navigation swipe gesture can be triggered with mouse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-05 01:49 PDT by Alice Mikhaylenko
Modified: 2021-07-05 22:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.14 KB, patch)
2021-07-05 02:41 PDT, Alice Mikhaylenko 		no flags Details | Formatted Diff | Diff
Patch (10.58 KB, patch)
2021-07-05 07:49 PDT, Alice Mikhaylenko 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Mikhaylenko 2021-07-05 01:49:08 PDT 
That's another regression from https://bugs.webkit.org/show_bug.cgi?id=212324, I noticed that the previous device type check got removed...
Comment 1 Alice Mikhaylenko 2021-07-05 02:41:21 PDT 
Created attachment 432877 [details]
Patch
Comment 2 EWS Watchlist 2021-07-05 02:42:10 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alice Mikhaylenko 2021-07-05 04:06:29 PDT 
Hm yes, there's also a GTK3-only code path in PageClientImpl.cpp. I hoped I can get away without a GTK3 build as well. :)
Comment 4 Alice Mikhaylenko 2021-07-05 07:49:55 PDT 
Created attachment 432885 [details]
Patch

Updated that codepath as well.
Comment 5 EWS 2021-07-05 22:45:30 PDT 
Committed r279574 (239405@main): <https://commits.webkit.org/239405@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432885 [details].