RESOLVED FIXED 227678
[GTK] Navigation swipe gesture can be triggered with mouse 
https://bugs.webkit.org/show_bug.cgi?id=227678
Summary [GTK] Navigation swipe gesture can be triggered with mouse
Alice Mikhaylenko
Reported 2021-07-05 01:49:08 PDT
That's another regression from https://bugs.webkit.org/show_bug.cgi?id=212324, I noticed that the previous device type check got removed...
Attachments
Patch (9.14 KB, patch)
2021-07-05 02:41 PDT, Alice Mikhaylenko 		no flags
DetailsFormatted DiffDiff
Patch (10.58 KB, patch)
2021-07-05 07:49 PDT, Alice Mikhaylenko 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alice Mikhaylenko
Comment 1 2021-07-05 02:41:21 PDT
Created attachment 432877 [details] Patch
EWS Watchlist
Comment 2 2021-07-05 02:42:10 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alice Mikhaylenko
Comment 3 2021-07-05 04:06:29 PDT
Hm yes, there's also a GTK3-only code path in PageClientImpl.cpp. I hoped I can get away without a GTK3 build as well. :)
Alice Mikhaylenko
Comment 4 2021-07-05 07:49:55 PDT
Created attachment 432885 [details] Patch Updated that codepath as well.
EWS
Comment 5 2021-07-05 22:45:30 PDT
Committed r279574 (239405@main): <https://commits.webkit.org/239405@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432885 [details].
Note You need to log in before you can comment on or make changes to this bug.