Bug 227668 - [WebIDL] Generate constructor's hash table in GenerateConstructorHelperMethods
Summary: [WebIDL] Generate constructor's hash table in GenerateConstructorHelperMethods
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on: 227275 227732
Blocks:
  Show dependency treegraph
 
Reported: 2021-07-03 15:35 PDT by Alexey Shvayka
Modified: 2021-07-06 20:11 PDT (History)
7 users (show)

See Also:


Attachments
Patch (22.28 KB, patch)
2021-07-03 15:37 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-07-03 15:35:08 PDT
[WebIDL] Generate constructor's hash table in GenerateConstructorHelperMethods
Comment 1 Alexey Shvayka 2021-07-03 15:37:44 PDT
Created attachment 432857 [details]
Patch
Comment 2 Alexey Shvayka 2021-07-04 11:27:44 PDT
Comment on attachment 432857 [details]
Patch

Thank you for reviews, Sam!
Comment 3 EWS 2021-07-04 11:38:03 PDT
Committed r279554 (239388@main): <https://commits.webkit.org/239388@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432857 [details].
Comment 4 Radar WebKit Bug Importer 2021-07-04 11:39:17 PDT
<rdar://problem/80153102>
Comment 5 WebKit Commit Bot 2021-07-06 20:09:35 PDT
Re-opened since this is blocked by bug 227732
Comment 6 Yusuke Suzuki 2021-07-06 20:11:20 PDT
https://trac.webkit.org/changeset/279546/webkit caused 2-3% regression in Speedometer2/jQuery-TodoMVC and it was hard to revert r279546 without reverting this change. Please reland this without r279546 change, thanks!