Bug 227543 - VisiblePosition::absoluteSelectionBoundsForLine fails on multiline vertical-rl content
Summary: VisiblePosition::absoluteSelectionBoundsForLine fails on multiline vertical-r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-30 14:12 PDT by zalan
Modified: 2021-07-01 06:29 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2021-06-30 15:26 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.32 KB, patch)
2021-06-30 21:33 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-06-30 14:12:25 PDT 
it does not compute the line position properly (missing writing direction flip).
Comment 1 zalan 2021-06-30 15:24:25 PDT 
<rdar://79887141>
Comment 2 zalan 2021-06-30 15:26:13 PDT 
Created attachment 432633 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-06-30 15:30:33 PDT 
Comment on attachment 432633 [details]
Patch

Can we make a test?
Comment 4 zalan 2021-06-30 21:33:52 PDT 
Created attachment 432658 [details]
Patch
Comment 5 EWS 2021-07-01 06:29:15 PDT 
Committed r279463 (239319@main): <https://commits.webkit.org/239319@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432658 [details].