Bug 227441 - Pass correct value of AX per app settings to the WebContent process
Summary: Pass correct value of AX per app settings to the WebContent process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-28 03:51 PDT by Per Arne Vollan
Modified: 2021-07-30 12:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.06 KB, patch)
2021-06-28 03:55 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.12 KB, patch)
2021-06-28 04:05 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-06-28 03:51:30 PDT 
Pass value of type AXValueState instead of a boolean value for per app AX settings.
Comment 1 Radar WebKit Bug Importer 2021-06-28 03:52:06 PDT 
<rdar://problem/79857797>
Comment 2 Per Arne Vollan 2021-06-28 03:55:00 PDT 
Created attachment 432379 [details]
Patch
Comment 3 Per Arne Vollan 2021-06-28 04:05:04 PDT 
Created attachment 432380 [details]
Patch
Comment 4 Brent Fulgham 2021-06-28 10:06:53 PDT 
Comment on attachment 432380 [details]
Patch

r=me
Comment 5 Per Arne Vollan 2021-06-28 10:22:40 PDT 
Comment on attachment 432380 [details]
Patch

Thanks for reviewing!
Comment 6 EWS 2021-06-28 10:41:35 PDT 
Committed r279342 (239210@main): <https://commits.webkit.org/239210@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432380 [details].
Comment 7 Simon Fraser (smfr) 2021-07-30 12:23:00 PDT 
Comment on attachment 432380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432380&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1095
> +    WTFLogAlways("AX: reduce motion: %d", (int)reduceMotionEnabled);

Ooops