Bug 22735 - Make Widget's frameRectsChanged() non-const
Summary: Make Widget's frameRectsChanged() non-const
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
Depends on:
Reported: 2008-12-08 05:56 PST by Tor Arne Vestbø
Modified: 2008-12-11 02:25 PST (History)
1 user (show)

See Also:

Initial patch (9.47 KB, patch)
2008-12-08 05:57 PST, Tor Arne Vestbø
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tor Arne Vestbø 2008-12-08 05:56:12 PST
It would make sense to make Widget::frameRectsChanged() and overrides non-const,
as this would hopefully allow us to get rid of some of the mutables in the classes that
react to the callback by changing their own state.
Comment 1 Tor Arne Vestbø 2008-12-08 05:57:18 PST
Created attachment 25839 [details]
Initial patch
Comment 2 Darin Adler 2008-12-08 10:28:12 PST
Comment on attachment 25839 [details]
Initial patch

seems fine, r=me
Comment 3 Holger Freyther 2008-12-11 02:25:55 PST
This did land in r39201.