Bug 227275 - [WebIDL] Rework runtime enabled properties leveraging PropertyCallback
Summary: [WebIDL] Rework runtime enabled properties leveraging PropertyCallback
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Alexey Shvayka
Keywords: InRadar
Depends on: 227732
Blocks: 158557 227668 227672 227673
  Show dependency treegraph
Reported: 2021-06-22 19:01 PDT by Alexey Shvayka
Modified: 2021-07-06 20:09 PDT (History)
15 users (show)

See Also:

Patch (807.57 KB, patch)
2021-07-02 12:21 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-06-22 19:01:15 PDT
This approach preserves HashTable's immutability while avoiding addition of extra checks to entry lookup and memory usage increase.
Enables removal of eager property reification in a follow-up change.
Comment 1 Radar WebKit Bug Importer 2021-06-29 19:02:15 PDT
Comment 2 Alexey Shvayka 2021-07-02 12:21:27 PDT
Created attachment 432811 [details]
Comment 3 Alexey Shvayka 2021-07-03 12:30:36 PDT
Comment on attachment 432811 [details]

This was already reviewed in https://bugs.webkit.org/show_bug.cgi?id=158557#c40, and should be safe (in terms of performance & web-compat) to land.
Comment 4 EWS 2021-07-03 12:57:57 PDT
Committed r279546 (239382@main): <https://commits.webkit.org/239382@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432811 [details].
Comment 5 Yusuke Suzuki 2021-07-06 19:50:09 PDT
This caused 2-3% regression in Speedometer/jQuery-TodoMVC on M1 macOS (not sure whether this is in Intel macOS).
Comment 6 WebKit Commit Bot 2021-07-06 20:09:33 PDT
Re-opened since this is blocked by bug 227732