WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
227166
[LFC][WPE] Build failure with GCC 8.x
https://bugs.webkit.org/show_bug.cgi?id=227166
Summary
[LFC][WPE] Build failure with GCC 8.x
Carlos Alberto Lopez Perez
Reported
2021-06-18 04:52:08 PDT
When building the WPE port with GCC 8.x (shipped by default on distros like Debian 10 or RHEL 8) the following build failure happens if LAYOUT_FORMATTING_CONTEXT is enabled: Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-207b877e-6.cpp.o [...] In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-207b877e-6.cpp:6: ../../Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp: In member function ‘void WebCore::LayoutIntegration::LineLayout::prepareLayoutState()’: ../../Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:253:36: error: converting to ‘std::optional<WebCore::Layout::Edges>’ from initializer list would use explicit constructor ‘constexpr std::optional<_Tp>::optional(std::in_place_t, _Args&& ...) [with _Args = {}; typename std::enable_if<is_constructible_v<_Tp, _Args&& ...>, bool>::type <anonymous> = 0; _Tp = WebCore::Layout::Edges]’ rootGeometry.setPadding({ { } }); ^ ../../Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:253:36: error: converting to ‘std::in_place_t’ from initializer list would use explicit constructor ‘constexpr std::in_place_t::in_place_t()’ ninja: build stopped: subcommand failed.
Attachments
Patch
(1.78 KB, patch)
2021-06-18 04:59 PDT
,
Carlos Alberto Lopez Perez
no flags
Details
Formatted Diff
Diff
Patch
(1.78 KB, patch)
2021-06-18 05:01 PDT
,
Carlos Alberto Lopez Perez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2021-06-18 04:59:53 PDT
Created
attachment 431769
[details]
Patch
Carlos Alberto Lopez Perez
Comment 2
2021-06-18 05:01:20 PDT
Created
attachment 431770
[details]
Patch
alan baradlay
Comment 3
2021-06-18 05:58:55 PDT
Comment on
attachment 431770
[details]
Patch Thanks for fixing it.
EWS
Comment 4
2021-06-18 06:38:01 PDT
Committed
r279036
(
238956@main
): <
https://commits.webkit.org/238956@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 431770
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug