Bug 227163 - makeUnique cannot be used to instantiate function-local classes
Summary: makeUnique cannot be used to instantiate function-local classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-18 01:34 PDT by Kimmo Kinnunen
Modified: 2021-06-21 11:49 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.46 KB, patch)
2021-06-18 03:08 PDT, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (8.66 KB, patch)
2021-06-18 04:31 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (10.50 KB, patch)
2021-06-18 04:40 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (10.50 KB, patch)
2021-06-21 01:11 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-06-18 01:34:13 PDT 
makeUnique cannot be used to instantiate function-local classes
This is due to WTF_MAKE_FAST_ALLOCATED causing warn-unused-typedef
Comment 1 Kimmo Kinnunen 2021-06-18 03:08:32 PDT 
Created attachment 431764 [details]
Patch
Comment 2 Antti Koivisto 2021-06-18 03:24:06 PDT 
Comment on attachment 431764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431764&action=review

> Source/WTF/wtf/FastMalloc.h:446
> +using __thisIsHereToForceASemicolonAfterThisMacro = int UNUSED_TYPE_ALIAS

There is a similar using line in IsoHeap.h. Maybe that needs fixing too?
Comment 3 Kimmo Kinnunen 2021-06-18 04:31:10 PDT 
Created attachment 431767 [details]
Patch
Comment 4 Kimmo Kinnunen 2021-06-18 04:40:46 PDT 
Created attachment 431768 [details]
Patch
Comment 5 Kimmo Kinnunen 2021-06-21 01:11:09 PDT 
Created attachment 431835 [details]
Patch
Comment 6 EWS 2021-06-21 11:48:38 PDT 
Committed r279073 (238993@main): <https://commits.webkit.org/238993@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431835 [details].
Comment 7 Radar WebKit Bug Importer 2021-06-21 11:49:28 PDT 
<rdar://problem/79573066>