Bug 22695 - CSSSelector needs to include OwnPtr.h
Summary: CSSSelector needs to include OwnPtr.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brett Wilson (Google)
Depends on:
Reported: 2008-12-05 14:53 PST by Brett Wilson (Google)
Modified: 2008-12-10 14:44 PST (History)
0 users

See Also:

Patch v1 (780 bytes, patch)
2008-12-05 14:54 PST, Brett Wilson (Google)
eric: review-
Details | Formatted Diff | Diff
Patch v2 (817 bytes, patch)
2008-12-05 15:19 PST, Brett Wilson (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Wilson (Google) 2008-12-05 14:53:48 PST
I get compile errors in Chromium (I think the other builds must use precompiled headers or something).
Comment 1 Brett Wilson (Google) 2008-12-05 14:54:08 PST
Created attachment 25791 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2008-12-05 15:11:18 PST
Comment on attachment 25791 [details]
Patch v1

Sigh.  I wish we already had build-webkit --chromium working so we could more easily test this in a public fashion.
Comment 3 Darin Adler 2008-12-05 15:15:55 PST
Comment on attachment 25791 [details]
Patch v1

This is wrong. It won't work on all platforms. The include needs to be <wtf/OwnPtr.h>, not just "OwnPtr.h". Also it's not in alphabetical order.
Comment 4 Eric Seidel (no email) 2008-12-05 15:17:50 PST
Comment on attachment 25791 [details]
Patch v1

Darin is totally right.  Reviewer fail. :(

Can you fix this please?  Otherwise I will.

My apologies to you both.
Comment 5 Brett Wilson (Google) 2008-12-05 15:19:04 PST
Created attachment 25792 [details]
Patch v2
Comment 6 Brett Wilson (Google) 2008-12-05 15:24:37 PST
Sorry about that, I fixed it.