Bug 226911 - [Live Text] Text selection inside image elements should not be cleared upon resize
Summary: [Live Text] Text selection inside image elements should not be cleared upon r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-10 20:45 PDT by Wenson Hsieh
Modified: 2021-06-11 12:56 PDT (History)
11 users (show)

See Also:

Attachments
For EWS (19.55 KB, patch)
2021-06-10 21:10 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Remove unnecessary include (19.35 KB, patch)
2021-06-10 21:12 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (19.35 KB, patch)
2021-06-11 11:13 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-06-10 20:45:49 PDT 
.
Comment 1 Wenson Hsieh 2021-06-10 21:10:59 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-06-10 21:12:18 PDT 
Created attachment 431177 [details]
Remove unnecessary include
Comment 3 Wenson Hsieh 2021-06-11 11:06:28 PDT 
Comment on attachment 431177 [details]
Remove unnecessary include

View in context: https://bugs.webkit.org/attachment.cgi?id=431177&action=review

Thanks for the review!

> Source/WebCore/ChangeLog:30
> +        Importantly, in step (1), we avoid regerating shadow DOM content in the case where the DOM elements already

(I just noticed "regerating" here. Will fix this up before landing)
Comment 4 Wenson Hsieh 2021-06-11 11:13:56 PDT 
Created attachment 431212 [details]
Patch for landing
Comment 5 EWS 2021-06-11 12:55:21 PDT 
Committed r278775 (238732@main): <https://commits.webkit.org/238732@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431212 [details].
Comment 6 Radar WebKit Bug Importer 2021-06-11 12:56:19 PDT 
<rdar://problem/79211968>