Bug 226891 - [webkitcorepy] 6x performance improvement in Memoized
Summary: [webkitcorepy] 6x performance improvement in Memoized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-10 11:48 PDT by Jonathan Bedard
Modified: 2021-06-10 14:11 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.27 KB, patch)
2021-06-10 11:50 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-06-10 11:48:46 PDT 
Dean originally noticed the high cost of inspect.getargspec, and if Memoized is on a hot code path, it can be pretty costly to tooling.
Comment 1 Radar WebKit Bug Importer 2021-06-10 11:49:10 PDT 
<rdar://problem/79151940>
Comment 2 Jonathan Bedard 2021-06-10 11:50:44 PDT 
Created attachment 431103 [details]
Patch
Comment 3 Dean Johnson 2021-06-10 12:49:46 PDT 
Comment on attachment 431103 [details]
Patch

Unofficial r+
Comment 4 EWS 2021-06-10 14:11:17 PDT 
Committed r278732 (238695@main): <https://commits.webkit.org/238695@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431103 [details].