Bug 226750 - [JSC] Rename *ByIdVariant to *ByVariant and *ByKind::Normal to *ByKind::ById
Summary: [JSC] Rename *ByIdVariant to *ByVariant and *ByKind::Normal to *ByKind::ById
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-07 18:39 PDT by Ross Kirsling
Modified: 2021-06-09 23:27 PDT (History)
12 users (show)

See Also:

Attachments
Patch (87.98 KB, patch)
2021-06-07 18:55 PDT, Ross Kirsling 		ysuzuki: review+
Details | Formatted Diff | Diff
Patch for landing (90.86 KB, patch)
2021-06-09 15:15 PDT, Ross Kirsling 		ross.kirsling: commit-queue+
Details | Formatted Diff | Diff
Patch for landing (90.86 KB, patch)
2021-06-09 20:56 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2021-06-07 18:39:25 PDT 
[JSC] Rename *ByIdVariant to *ByVariant and *ByKind::Normal to *ByKind::ById
Comment 1 Ross Kirsling 2021-06-07 18:55:55 PDT 
Created attachment 430798 [details]
Patch
Comment 2 Yusuke Suzuki 2021-06-09 12:09:23 PDT 
Comment on attachment 430798 [details]
Patch

r=me. Maybe, you need rebaseline.
Comment 3 Ross Kirsling 2021-06-09 15:15:24 PDT 
Created attachment 431017 [details]
Patch for landing
Comment 4 EWS 2021-06-09 20:02:45 PDT 
Found 1 new test failure: imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html
Comment 5 Ross Kirsling 2021-06-09 20:56:07 PDT 
Created attachment 431046 [details]
Patch for landing
Comment 6 EWS 2021-06-09 23:26:19 PDT 
Committed r278696 (238668@main): <https://commits.webkit.org/238668@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431046 [details].
Comment 7 Radar WebKit Bug Importer 2021-06-09 23:27:18 PDT 
<rdar://problem/79123276>