rdar://78136095
Created attachment 430541 [details] For EWS
Comment on attachment 430541 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=430541&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10386 > + })(); I'm unsure why this is a block instead of just a pre-calculated bool. I'm guessing that it's because you can more easily write the logic?
Comment on attachment 430541 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=430541&action=review Thanks for the review! >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10386 >> + })(); > > I'm unsure why this is a block instead of just a pre-calculated bool. I'm guessing that it's because you can more easily write the logic? Indeed — I turned this into a block so that I could use early returns for each of the cases where we can show a preview (I feel that it's *slightly* cleaner than having it all on one line)
Committed r278459 (238479@main): <https://commits.webkit.org/238479@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430541 [details].