Bug 226625 – [iOS] Long pressing images on 9gag.com fails to present context menus

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

rdar://78136095

[Wenson Hsieh]

Created attachment 430541 [details]
For EWS

[Megan Gardner]

Comment on attachment 430541 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=430541&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10386
> +        })();

I'm unsure why this is a block instead of just a pre-calculated bool. I'm guessing that it's because you can more easily write the logic?

[Wenson Hsieh]

Comment on attachment 430541 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=430541&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10386
>> +        })();
> 
> I'm unsure why this is a block instead of just a pre-calculated bool. I'm guessing that it's because you can more easily write the logic?

Indeed — I turned this into a block so that I could use early returns for each of the cases where we can show a preview (I feel that it's *slightly* cleaner than having it all on one line)

[EWS]

Committed r278459 (238479@main): <https://commits.webkit.org/238479@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430541 [details].