Bug 226617 - [Python-3] Change shebangs in JSC/inspector/scripts to Python 3
Summary: [Python-3] Change shebangs in JSC/inspector/scripts to Python 3
Status: RESOLVED DUPLICATE of bug 231587
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: hysu
URL:
Keywords: InRadar
Depends on:
Blocks: 226631
  Show dependency treegraph
 
Reported: 2021-06-03 18:05 PDT by hysu
Modified: 2023-08-31 05:49 PDT (History)
13 users (show)

See Also:


Attachments
Patch (19.11 KB, patch)
2021-06-03 18:54 PDT, hysu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description hysu 2021-06-03 18:05:12 PDT
Breaking up an effort to make Python scripts in the JSC build process use Python 3 by default into multiple patches. This patch addresses the ./inspector/scripts/ directory.
Comment 1 hysu 2021-06-03 18:54:31 PDT
Created attachment 430530 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-06-03 18:54:56 PDT
<rdar://problem/78848866>
Comment 3 EWS Watchlist 2021-06-03 18:55:15 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 hysu 2021-06-03 18:56:08 PDT
(Submitting this patch first as --no-review to see if it gets past EWS)
Comment 5 Jonathan Bedard 2021-06-04 12:16:49 PDT
Comment on attachment 430530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430530&action=review

> Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:1
> +#!/usr/bin/env python3

Make sure that we cover any callers of these too, which may be calling via "python Source...."
Comment 6 Jonathan Bedard 2021-06-04 12:20:17 PDT
Comment on attachment 430530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430530&action=review

> Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:1
> +#!/usr/bin/env python3

Looks like this is the root script, we need to make sure it's callers are invoking it with Python3
Comment 7 Sam Sneddon [:gsnedders] 2023-08-31 05:49:54 PDT

*** This bug has been marked as a duplicate of bug 231587 ***