Bug 226203 - [WebDriver][WPE] Support running w3c webdriver tests with Cog
Summary: [WebDriver][WPE] Support running w3c webdriver tests with Cog
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-24 18:07 PDT by Lauro Moura
Modified: 2021-05-25 07:47 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.77 KB, patch)
2021-05-24 18:08 PDT, Lauro Moura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-05-24 18:07:40 PDT 
[WebDriver][WPE] Support running w3c webdriver tests with Cog
Comment 1 Lauro Moura 2021-05-24 18:08:43 PDT 
Created attachment 429604 [details]
Patch
Comment 2 Adrian Perez 2021-05-25 06:59:43 PDT 
Do I understand correctly that we would need the following patch 
applied in Cog first?

   https://github.com/Igalia/cog/pull/305
Comment 3 Lauro Moura 2021-05-25 07:35:26 PDT 
(In reply to Adrian Perez from comment #2)
> Do I understand correctly that we would need the following patch 
> applied in Cog first?
> 
>    https://github.com/Igalia/cog/pull/305

They are related but independent. Without the pull request, Cog would just fail the entire suite. run-minibrowser still works normally.

In fact, applying this one first would make testing the Cog pull request easier. 

PS: Btw, I'm updating the Cog PR later today.
Comment 4 EWS 2021-05-25 07:46:06 PDT 
Committed r278006 (238119@main): <https://commits.webkit.org/238119@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429604 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-25 07:47:20 PDT 
<rdar://problem/78456233>