Bug 226160 - DestinationColorSpace's well known color space accessors cause unnecessary retain count churn
Summary: DestinationColorSpace's well known color space accessors cause unnecessary re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-23 18:07 PDT by Sam Weinig
Modified: 2021-05-24 20:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.49 KB, patch)
2021-05-23 18:10 PDT, Sam Weinig 		darin: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.46 KB, patch)
2021-05-24 19:53 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-05-23 18:07:45 PDT 
DestinationColorSpace's well known color space accessors cause unnecessary retain count churn
Comment 1 Sam Weinig 2021-05-23 18:10:38 PDT 
Created attachment 429492 [details]
Patch
Comment 2 Darin Adler 2021-05-24 14:24:49 PDT 
Comment on attachment 429492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429492&action=review

> Source/WebCore/platform/graphics/DestinationColorSpace.cpp:41
> +template<KnownColorSpaceAccessor knownColorSpaceAccessor> static const DestinationColorSpace& knownColorSpace()

Template parameter could just be named accessor.
Comment 3 EWS 2021-05-24 14:25:20 PDT 
Tools/Scripts/svn-apply failed to apply attachment 429492 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 4 Sam Weinig 2021-05-24 19:53:36 PDT 
Created attachment 429615 [details]
Patch
Comment 5 EWS 2021-05-24 20:36:17 PDT 
Committed r277994 (238107@main): <https://commits.webkit.org/238107@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429615 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-24 20:37:15 PDT 
<rdar://problem/78433657>