Bug 226098 - Adopt CheckedLock in RemoteImageBufferProxy
Summary: Adopt CheckedLock in RemoteImageBufferProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-21 11:57 PDT by Chris Dumez
Modified: 2021-05-21 15:16 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.81 KB, patch)
2021-05-21 12:03 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (3.80 KB, patch)
2021-05-21 12:08 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-21 11:57:48 PDT
Adopt CheckedLock in RemoteImageBufferProxy to benefit from Clang Thread Safety Analysis.
Comment 1 Chris Dumez 2021-05-21 12:03:47 PDT
Created attachment 429318 [details]
Patch
Comment 2 Tim Horton 2021-05-21 12:06:45 PDT
Comment on attachment 429318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429318&action=review

> Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:116
> +    // only get modified on the main thread.

`gets`
Comment 3 Chris Dumez 2021-05-21 12:08:34 PDT
Created attachment 429320 [details]
Patch
Comment 4 EWS 2021-05-21 15:15:05 PDT
Committed r277892 (238028@main): <https://commits.webkit.org/238028@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429320 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-21 15:16:22 PDT
<rdar://problem/78331181>