Bug 226074 - Fix use after move bug in WebXRSession
Summary: Fix use after move bug in WebXRSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Imanol Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks: 208988
  Show dependency tree / graph
 
Reported: 2021-05-21 03:29 PDT by Imanol Fernandez
Modified: 2021-05-21 08:56 PDT (History)
4 users (show)

See Also:

Attachments
Patch (14.91 KB, patch)
2021-05-21 03:53 PDT, Imanol Fernandez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.88 KB, patch)
2021-05-21 04:51 PDT, Imanol Fernandez 		no flags Details | Formatted Diff | Diff
Patch for landing (14.93 KB, patch)
2021-05-21 08:13 PDT, Imanol Fernandez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Imanol Fernandez 2021-05-21 03:29:10 PDT 
There is a FrameData use after move in WebXR session, which is causing most of WebXR tests to fail while testing WPE. This is a regression from Bug 225428.
Comment 1 Imanol Fernandez 2021-05-21 03:53:04 PDT 
Created attachment 429281 [details]
Patch
Comment 2 Imanol Fernandez 2021-05-21 04:51:43 PDT 
Created attachment 429284 [details]
Patch

Fix compilation failure in Cocoa
Comment 3 EWS 2021-05-21 08:01:39 PDT 
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 4 Imanol Fernandez 2021-05-21 08:13:21 PDT 
Created attachment 429291 [details]
Patch for landing
Comment 5 EWS 2021-05-21 08:55:52 PDT 
Committed r277862 (238004@main): <https://commits.webkit.org/238004@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429291 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-21 08:56:16 PDT 
<rdar://problem/78312361>