Bug 22606 - Can <th> serves as the AXTitleUIElement for <td>?
Summary: Can <th> serves as the AXTitleUIElement for <td>?
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-02 14:59 PST by chris fleizach
Modified: 2008-12-02 17:04 PST (History)
0 users

See Also:


Attachments
patch to make <th> behave as title ui element (23.58 KB, patch)
2008-12-02 15:16 PST, chris fleizach
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2008-12-02 14:59:53 PST
Given that <th> is the header for a <td> cell, is it possible to link the <th> AX objet as the AXTitleUIElemlent of <td> AX object?

I've seen text label with <th> and its input text field with <td>.  That would be a good example where it would be nice to make a connection between the two.
Comment 1 chris fleizach 2008-12-02 15:16:22 PST
Created attachment 25687 [details]
patch to make <th> behave as title ui element
Comment 2 Beth Dakin 2008-12-02 15:38:24 PST
Comment on attachment 25687 [details]
patch to make <th> behave as title ui element

This is a nitpick, but we generally sentence-case our comments. I would appreciate it if you would do that in the comments below. (Meaning, capitalize the first letter of the first work in each sentence. 

> +    // try to find if the first cell in this row is a <th>. if it is,
> +    // then it can act as the title ui element. (this is only in the
> +    // case when the table is not appearing as an AXTable)
> +    if (!m_renderer || isTableCell())
> +        return 0;


And here:
> +    // if this cell is in the first column, there is no need to continue
> +    int col = renderCell->col();
Comment 3 chris fleizach 2008-12-02 17:04:14 PST
http://trac.webkit.org/changeset/38927