Bug 226026 - Use CheckedLock more in WebCore
Summary: Use CheckedLock more in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-20 10:22 PDT by Chris Dumez
Modified: 2021-05-20 12:24 PDT (History)
26 users (show)

See Also:

Attachments
Patch (113.52 KB, patch)
2021-05-20 10:24 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-20 10:22:12 PDT 
Use CheckedLock more in WebCore to benefit from Clang Thread Safety Analysis.
Comment 1 Chris Dumez 2021-05-20 10:24:32 PDT 
Created attachment 429184 [details]
Patch
Comment 2 Geoffrey Garen 2021-05-20 11:23:02 PDT 
Comment on attachment 429184 [details]
Patch

rs=me

Pretty cool!
Comment 3 EWS 2021-05-20 11:41:42 PDT 
Committed r277805 (237960@main): <https://commits.webkit.org/237960@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429184 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-20 11:42:34 PDT 
<rdar://problem/78269193>
Comment 5 Joseph Pecoraro 2021-05-20 12:24:07 PDT 
Comment on attachment 429184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429184&action=review

> Source/WebCore/page/WheelEventTestMonitor.cpp:117
> +    Locker locker { m_lock };

Nice!