RESOLVED FIXED 225834
Allow wheel events to be coalesced during scroll deceleration 
https://bugs.webkit.org/show_bug.cgi?id=225834
Summary Allow wheel events to be coalesced during scroll deceleration
Simon Fraser (smfr)
Reported 2021-05-14 17:00:15 PDT
Allow wheel events to be coalesced during scroll deceleration
Attachments
Patch (8.99 KB, patch)
2021-05-14 17:43 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (9.02 KB, patch)
2021-05-14 20:28 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-05-14 17:43:15 PDT
Created attachment 428692 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-05-14 17:43:47 PDT
<rdar://70402512>
Tim Horton
Comment 3 2021-05-14 17:51:48 PDT
Comment on attachment 428692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428692&action=review > Source/WebKit/Shared/WebWheelEventCoalescer.cpp:152 > + static constexpr double momentumVelocityEventFrequencyReductionThreashold = 320.0; // Points per second. Threashold!
Sam Weinig
Comment 4 2021-05-14 17:58:55 PDT
Comment on attachment 428692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428692&action=review > Source/WebKit/Shared/WebWheelEventCoalescer.cpp:90 > +bool WebWheelEventCoalescer::isInMomentumPhase(const WebWheelEvent& event) This feels like an odd name for what this checks. It should either have a more descriptive name or at least have a comment explaining things. > Source/WebKit/Shared/WebWheelEventCoalescer.cpp:151 > + if (isInMomentumPhase(event) && shouldCoalesceEventsDuringDeceleration() && lastEventInterval && lastEventInterval) { "lastEventInterval && lastEventInterval" seems duplicated. > Source/WebKit/Shared/WebWheelEventCoalescer.cpp:152 > + static constexpr double momentumVelocityEventFrequencyReductionThreashold = 320.0; // Points per second. No need for the static here. > Source/WebKit/Shared/WebWheelEventCoalescer.cpp:155 > + static constexpr auto maxCoalescingInterval = WebCore::FullSpeedAnimationInterval; No need for the static here. > Source/WebKit/UIProcess/WebPageProxy.cpp:2829 > + auto framesPerSecond = m_process->processPool().nominalFramesPerSecondForDisplay(*m_displayID); Not new, but it is still bizarre this on the process pool.
Simon Fraser (smfr)
Comment 5 2021-05-14 20:28:25 PDT
Created attachment 428704 [details] Patch
Simon Fraser (smfr)
Comment 6 2021-05-17 11:00:13 PDT
Comment on attachment 428704 [details] Patch http://trac.webkit.org/changeset/277587/webkit
Note You need to log in before you can comment on or make changes to this bug.