Allow wheel events to be coalesced during scroll deceleration
Created attachment 428692 [details] Patch
<rdar://70402512>
Comment on attachment 428692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428692&action=review > Source/WebKit/Shared/WebWheelEventCoalescer.cpp:152 > + static constexpr double momentumVelocityEventFrequencyReductionThreashold = 320.0; // Points per second. Threashold!
Comment on attachment 428692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428692&action=review > Source/WebKit/Shared/WebWheelEventCoalescer.cpp:90 > +bool WebWheelEventCoalescer::isInMomentumPhase(const WebWheelEvent& event) This feels like an odd name for what this checks. It should either have a more descriptive name or at least have a comment explaining things. > Source/WebKit/Shared/WebWheelEventCoalescer.cpp:151 > + if (isInMomentumPhase(event) && shouldCoalesceEventsDuringDeceleration() && lastEventInterval && lastEventInterval) { "lastEventInterval && lastEventInterval" seems duplicated. > Source/WebKit/Shared/WebWheelEventCoalescer.cpp:152 > + static constexpr double momentumVelocityEventFrequencyReductionThreashold = 320.0; // Points per second. No need for the static here. > Source/WebKit/Shared/WebWheelEventCoalescer.cpp:155 > + static constexpr auto maxCoalescingInterval = WebCore::FullSpeedAnimationInterval; No need for the static here. > Source/WebKit/UIProcess/WebPageProxy.cpp:2829 > + auto framesPerSecond = m_process->processPool().nominalFramesPerSecondForDisplay(*m_displayID); Not new, but it is still bizarre this on the process pool.
Created attachment 428704 [details] Patch
Comment on attachment 428704 [details] Patch http://trac.webkit.org/changeset/277587/webkit