Bug 225827 - report-non-inclusive-language should skip node_modules directory
Summary: report-non-inclusive-language should skip node_modules directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 213092
  Show dependency tree / graph
 
Reported: 2021-05-14 15:02 PDT by Aakash Jain
Modified: 2021-05-17 10:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2021-05-14 15:04 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-05-14 15:02:26 PDT 
node_modules contain external code. Some of the modules might contain non-inclusive language. report-non-inclusive-language script should skip node_modules.

e.g.: 
https://github.com/WebKit/WebKit/tree/main/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules
https://github.com/WebKit/WebKit/tree/main/Websites/browserbench.org/Speedometer2.0/resources/todomvc/architecture-examples/angularjs/node_modules
Comment 1 Aakash Jain 2021-05-14 15:04:02 PDT 
Created attachment 428667 [details]
Patch
Comment 2 EWS 2021-05-15 04:00:54 PDT 
Committed r277537 (237765@main): <https://commits.webkit.org/237765@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428667 [details].
Comment 3 Radar WebKit Bug Importer 2021-05-15 04:01:22 PDT 
<rdar://problem/78054158>