Bug 225824 - DFGVarargsForwardingPhase shouldn't consult Flush
Summary: DFGVarargsForwardingPhase shouldn't consult Flush
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-14 14:34 PDT by Saam Barati
Modified: 2021-05-16 00:31 PDT (History)
9 users (show)

See Also:

Attachments
patch (2.07 KB, patch)
2021-05-14 14:48 PDT, Saam Barati 		fpizlo: review+
Details | Formatted Diff | Diff
patch for landing (3.38 KB, patch)
2021-05-14 15:14 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-05-14 14:34:25 PDT 
...
Comment 1 Saam Barati 2021-05-14 14:48:27 PDT 
Created attachment 428664 [details]
patch
Comment 2 Yusuke Suzuki 2021-05-14 14:51:21 PDT 
Comment on attachment 428664 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428664&action=review

r=me too

> Source/JavaScriptCore/ChangeLog:23
> +        This is a 0.5% Speedometer progression.

Can we have some microbenchmarks that ensures this is working?
Comment 3 Saam Barati 2021-05-14 15:14:31 PDT 
Created attachment 428670 [details]
patch for landing
Comment 4 EWS 2021-05-16 00:30:47 PDT 
Committed r277565 (237793@main): <https://commits.webkit.org/237793@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428670 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-16 00:31:17 PDT 
<rdar://problem/78071191>