RESOLVED FIXED 225763
[GTK] MiniBrowser: add support for saving multiple tabs in session state 
https://bugs.webkit.org/show_bug.cgi?id=225763
Summary [GTK] MiniBrowser: add support for saving multiple tabs in session state
Carlos Garcia Campos
Reported 2021-05-13 04:59:12 PDT
We currently save the active tab when the window is closed.
Attachments
Patch (7.56 KB, patch)
2021-05-13 05:02 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-05-13 05:02:07 PDT
Created attachment 428489 [details] Patch
Michael Catanzaro
Comment 2 2021-05-13 07:14:58 PDT
Comment on attachment 428489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428489&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:1463 > + if (!g_key_file_load_from_file(session, sessionFile, G_KEY_FILE_NONE, NULL)) { I would check and print a warning if !g_error_matches(error, G_FILE_ERROR, G_FILE_ERROR_NOENT). I think that's the only case where failure to restore the session is expected. If the session state file contains data and we fail to restore it, then that's probably a bug and warning developers is good to do. > Tools/MiniBrowser/gtk/BrowserWindow.c:1476 > + > + return; This extra blank line doesn't seem like your usual code style?
Carlos Garcia Campos
Comment 3 2021-06-04 03:43:50 PDT
Committed r278451 (238471@main): <https://commits.webkit.org/238471@main>
Note You need to log in before you can comment on or make changes to this bug.