Bug 225715 - [WinCairo] Failed to open WebInspector UI since r277231
Summary: [WinCairo] Failed to open WebInspector UI since r277231
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-12 13:43 PDT by Fujii Hironori
Modified: 2021-05-12 19:36 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.13 KB, patch)
2021-05-12 14:05 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-05-12 13:43:16 PDT
[WinCairo] Failed to open WebInspector UI since r277231

In InspectorResourceURLSchemeHandler::platformStartTask

requestURL is "inspector-resource:///Main.html".
However, it is mapped to "C:\\Main.html". It should be
"C:\\path-to-webkit-build-dir\\bin64\\WebKit.resources\\WebInspectorUI\\Main.html"

Bug 225550 – Port Filesystem::pathByAppendingComponent() & Filesystem:: pathByAppendingComponents() to std::filesystem
Bug 223619 – [WinCairo] Implement inspector-resource:// URL scheme handler for Web Inspector resources
Comment 1 Fujii Hironori 2021-05-12 14:05:01 PDT
Created attachment 428417 [details]
Patch
Comment 2 Fujii Hironori 2021-05-12 19:35:45 PDT
Comment on attachment 428417 [details]
Patch

Clearing flags on attachment: 428417

Committed r277417 (237667@main): <https://commits.webkit.org/237667@main>
Comment 3 Fujii Hironori 2021-05-12 19:35:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2021-05-12 19:36:14 PDT
<rdar://problem/77947346>